http - ClientRequest emits hang up error instead of 'aborted'

[ronag]

Currently, ClientRequest will emit an 'error' instead of 'aborted' when the connection is closed before response. Is that really correct?

https://github.com/nodejs/node/pull/15270/files#r137951611

[mscdex]

To me, 'aborted' indicates an explicit abort was requested at some point in the past. I don't think we should be emitting that same event if the server did not send back a complete response.

[ronag]

@mscdex: Currently the request object never fires the aborted event even though the docs state:

Emitted when the request has been aborted by the server and the network socket has closed.

The explicit abort is given by the abort event as stated by the docs:

Emitted when the request has been aborted by the client. This event is only emitted on the first call to abort().

[ronag]

The http/2 compat seems to fire the aborted event on the request object so there is at the least an inconsistency here.

[ronag]

Actually, the http/2 compat does the reverse, it fires aborted only on the request object, but not the response object (which kind of makes more sense to me).

[mcollina]

can you please make an example of what happens in http and what happens in http2?