From fc41817f97580da8af2ef4e5dbfa36d02d63b9fc Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Mon, 2 Apr 2018 08:09:29 -0700 Subject: [PATCH] =?UTF-8?q?tools:=20don=E2=80=99t=20emit=20illegal=20utf-8?= =?UTF-8?q?=20from=20icutrim/iculslocs?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - argv[0] was being emitted into a utf-8 stream, but argv[0] may not be legal utf-8 - fix by not emitting argv[0] (was only for a source comment) - partially resolves https://github.com/nodejs/node/issues/17077 PR-URL: https://github.com/nodejs/node/pull/19756 Fixes: https://github.com/nodejs/node/issues/17077 Reviewed-By: Anna Henningsen Reviewed-By: Nikolai Vavilov Reviewed-By: Ben Noordhuis Reviewed-By: James M Snell --- tools/icu/iculslocs.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/icu/iculslocs.cc b/tools/icu/iculslocs.cc index 3ceb8d2a4d81d0..24bc6287ea8131 100644 --- a/tools/icu/iculslocs.cc +++ b/tools/icu/iculslocs.cc @@ -270,9 +270,9 @@ int list(const char* toBundle) { if (bf != NULL) { // NOLINT (readability/null_usage) // write the HEADER fprintf(bf, - "// Warning this file is automatically generated\n" - "// Updated by %s based on %s:%s.txt\n", - PROG, + "// NOTE: This file was generated during the build process.\n" + "// Generator: tools/icu/iculslocs.cc\n" + "// Input package-tree/item: %s/%s.res\n", packageName.data(), locale); fprintf(bf,