From e2541303f315904bb0233f4cb832208fb5e12f2f Mon Sep 17 00:00:00 2001 From: ZYSzys Date: Wed, 22 Aug 2018 01:28:18 +0800 Subject: [PATCH] doc: tweak macOS-firewall note position Move the macOS-firewall note to the end of "Building Node.js" and above "Running Tests". I think it's more reasonable when user prepare to build node step by step. Just read and build from top to end in case ignore the note. PR-URL: https://github.com/nodejs/node/pull/22440 Reviewed-By: Luigi Pinca Reviewed-By: Vse Mozhet Byt Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Trivikram Kamat Reviewed-By: Michael Dawson --- BUILDING.md | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 613d4d801b8118..73e685784559aa 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -135,17 +135,6 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and If the path to your build directory contains a space, the build will likely fail. -After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid -popups asking to accept incoming network connections when running tests. - -Running the following script on macOS will add the firewall rules for the -executable `node` in the `out` directory and the symbolic `node` link in the -project's root directory. - -```console -$ sudo ./tools/macos-firewall.sh -``` - On FreeBSD and OpenBSD, you may also need: * libexecinfo @@ -169,6 +158,17 @@ for more information. Note that the above requires that `python` resolve to Python 2.6 or 2.7 and not a newer version. +After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid +popups asking to accept incoming network connections when running tests. + +Running the following script on macOS will add the firewall rules for the +executable `node` in the `out` directory and the symbolic `node` link in the +project's root directory. + +```console +$ sudo ./tools/macos-firewall.sh +``` + #### Running Tests To verify the build: