From b85a73407b4b321b41980330490ec2433d05d08c Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Thu, 24 Aug 2017 22:18:47 -0700
Subject: [PATCH] test: improve test-abort-uncaught-exception

Add `SIGTRAP` to allowed signals (seen on PPC machines in CI).

Improve message when assertion fails in test-abort-uncaught-exception by
providing the signal name that was not expected.

PR-URL: https://github.com/nodejs/node/pull/14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
---
 test/abort/test-abort-uncaught-exception.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/abort/test-abort-uncaught-exception.js b/test/abort/test-abort-uncaught-exception.js
index f9847193769d2d..efb5aa9b8b8285 100644
--- a/test/abort/test-abort-uncaught-exception.js
+++ b/test/abort/test-abort-uncaught-exception.js
@@ -9,7 +9,7 @@ if (process.argv[2] === 'child') {
   throw new Error('child error');
 } else {
   run('', null);
-  run('--abort-on-uncaught-exception', ['SIGABRT', 'SIGILL']);
+  run('--abort-on-uncaught-exception', ['SIGABRT', 'SIGTRAP', 'SIGILL']);
 }
 
 function run(flags, signals) {
@@ -26,7 +26,7 @@ function run(flags, signals) {
         assert.strictEqual(code, 1);
     } else {
       if (signals)
-        assert.strictEqual(signals.includes(sig), true);
+        assert(signals.includes(sig), `Unexpected signal ${sig}`);
       else
         assert.strictEqual(sig, null);
     }