From 93416e9b7a83e1c45375efa3e89cc5d04a29fff1 Mon Sep 17 00:00:00 2001 From: Brian White Date: Mon, 20 Feb 2017 08:26:51 -0500 Subject: [PATCH] build: fix newlines in addon build output Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead. PR-URL: https://github.com/nodejs/node/pull/11466 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 53a61c43572699..4bdda8b8f54e50 100644 --- a/Makefile +++ b/Makefile @@ -169,7 +169,7 @@ test/addons/.buildstamp: config.gypi \ # Cannot use $(wildcard test/addons/*/) here, it's evaluated before # embedded addons have been generated from the documentation. @for dirname in test/addons/*/; do \ - echo "\nBuilding addon $$PWD/$$dirname" ; \ + printf "\nBuilding addon $$PWD/$$dirname\n" ; \ env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \ --loglevel=$(LOGLEVEL) rebuild \ --python="$(PYTHON)" \