From 7cd8bb26d1e9f292af74b2a0d86dc025cbd7f458 Mon Sep 17 00:00:00 2001
From: marco-ippolito <marcoippolito54@gmail.com>
Date: Mon, 29 Apr 2024 10:33:39 +0200
Subject: [PATCH] util: move util.isNull to eol
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR-URL: https://github.com/nodejs/node/pull/52744
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 doc/api/deprecations.md    |  8 +++++---
 doc/api/util.md            | 26 --------------------------
 lib/util.js                | 12 ------------
 test/parallel/test-util.js |  5 -----
 4 files changed, 5 insertions(+), 46 deletions(-)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index 1852bfadb70779..9fd2794f3a48a4 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -1123,6 +1123,9 @@ The [`util.isFunction()`][] API is deprecated. Please use
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/52744
+    description: End-of-Life deprecation.
   - version: v22.0.0
     pr-url: https://github.com/nodejs/node/pull/50488
     description: Runtime deprecation.
@@ -1138,9 +1141,9 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Runtime
+Type: End-of-Life
 
-The [`util.isNull()`][] API is deprecated. Please use
+The `util.isNull()` API has been removed. Please use
 `arg === null` instead.
 
 ### DEP0051: `util.isNullOrUndefined()`
@@ -3784,7 +3787,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
 [`util.isArray()`]: util.md#utilisarrayobject
 [`util.isError()`]: util.md#utiliserrorobject
 [`util.isFunction()`]: util.md#utilisfunctionobject
-[`util.isNull()`]: util.md#utilisnullobject
 [`util.isNullOrUndefined()`]: util.md#utilisnullorundefinedobject
 [`util.isNumber()`]: util.md#utilisnumberobject
 [`util.isObject()`]: util.md#utilisobjectobject
diff --git a/doc/api/util.md b/doc/api/util.md
index 7eac4afa2c7835..ec6892ebb1043a 100644
--- a/doc/api/util.md
+++ b/doc/api/util.md
@@ -3045,32 +3045,6 @@ util.isFunction(Bar);
 // Returns: true
 ```
 
-### `util.isNull(object)`
-
-<!-- YAML
-added: v0.11.5
-deprecated: v4.0.0
--->
-
-> Stability: 0 - Deprecated: Use `value === null` instead.
-
-* `object` {any}
-* Returns: {boolean}
-
-Returns `true` if the given `object` is strictly `null`. Otherwise, returns
-`false`.
-
-```js
-const util = require('node:util');
-
-util.isNull(0);
-// Returns: false
-util.isNull(undefined);
-// Returns: false
-util.isNull(null);
-// Returns: true
-```
-
 ### `util.isNullOrUndefined(object)`
 
 <!-- YAML
diff --git a/lib/util.js b/lib/util.js
index 6d9d5a3bd90f8c..671a6f660016b0 100644
--- a/lib/util.js
+++ b/lib/util.js
@@ -90,15 +90,6 @@ function lazyAbortController() {
 
 let internalDeepEqual;
 
-/**
- * @deprecated since v4.0.0
- * @param {any} arg
- * @returns {arg is null}
- */
-function isNull(arg) {
-  return arg === null;
-}
-
 /**
  * @deprecated since v4.0.0
  * @param {any} arg
@@ -416,9 +407,6 @@ module.exports = {
     }
     return internalDeepEqual(a, b);
   },
-  isNull: deprecate(isNull,
-                    'The `util.isNull` API is deprecated. Please use `arg === null` instead.',
-                    'DEP0050'),
   isNullOrUndefined: deprecate(isNullOrUndefined,
                                'The `util.isNullOrUndefined` API is deprecated. ' +
                                'Please use `arg === null || arg === undefined` instead.',
diff --git a/test/parallel/test-util.js b/test/parallel/test-util.js
index d1b4d9a995b5dd..d041287560f6a9 100644
--- a/test/parallel/test-util.js
+++ b/test/parallel/test-util.js
@@ -98,11 +98,6 @@ assert.strictEqual(util.isPrimitive(Infinity), true);
 assert.strictEqual(util.isPrimitive(NaN), true);
 assert.strictEqual(util.isPrimitive(Symbol('symbol')), true);
 
-assert.strictEqual(util.isNull(null), true);
-assert.strictEqual(util.isNull(undefined), false);
-assert.strictEqual(util.isNull(), false);
-assert.strictEqual(util.isNull('string'), false);
-
 assert.strictEqual(util.isUndefined(undefined), true);
 assert.strictEqual(util.isUndefined(), true);
 assert.strictEqual(util.isUndefined(null), false);