From 78ebc378a5fd12a004fa7ec86c21ad76c0e98216 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 27 Oct 2017 18:16:28 -0700 Subject: [PATCH] squash: arguments --- benchmark/util/format.js | 3 +++ benchmark/util/inspect-array.js | 3 +++ benchmark/util/type-check.js | 3 +++ test/parallel/test-benchmark-util.js | 9 ++++++++- 4 files changed, 17 insertions(+), 1 deletion(-) diff --git a/benchmark/util/format.js b/benchmark/util/format.js index 6f171318ee28bf..5f9c4c3b594497 100644 --- a/benchmark/util/format.js +++ b/benchmark/util/format.js @@ -21,6 +21,9 @@ const bench = common.createBenchmark(main, { }); function main({ n, type }) { + // For testing, if supplied with an empty type, default to string. + type = type || 'string'; + const [first, second] = inputs[type]; bench.start(); diff --git a/benchmark/util/inspect-array.js b/benchmark/util/inspect-array.js index 751e2c3c2deb8f..74332d18579865 100644 --- a/benchmark/util/inspect-array.js +++ b/benchmark/util/inspect-array.js @@ -18,6 +18,9 @@ function main({ n, len, type }) { var arr = Array(len); var i, opts; + // For testing, if supplied with an empty type, default to denseArray. + type = type || 'denseArray'; + switch (type) { case 'denseArray_showHidden': opts = { showHidden: true }; diff --git a/benchmark/util/type-check.js b/benchmark/util/type-check.js index 3b7b090c2e3957..ee8dd7e4ece188 100644 --- a/benchmark/util/type-check.js +++ b/benchmark/util/type-check.js @@ -35,6 +35,9 @@ const bench = common.createBenchmark(main, { }); function main(conf) { + // For testing, if supplied with an empty type, default to ArrayBufferView. + conf.type = conf.type || 'ArrayBufferView'; + const util = process.binding('util'); const types = require('internal/util/types'); diff --git a/test/parallel/test-benchmark-util.js b/test/parallel/test-benchmark-util.js index d01eafd7d3262a..25140f8fe7ebc1 100644 --- a/test/parallel/test-benchmark-util.js +++ b/test/parallel/test-benchmark-util.js @@ -4,4 +4,11 @@ require('../common'); const runBenchmark = require('../common/benchmark'); -runBenchmark('util', ['n=1']); +runBenchmark('util', + ['argument=false', + 'input=', + 'method=Array', + 'n=1', + 'option=none', + 'type=', + 'version=native']);