From 56530c13cc5095df13ed09f570e4c3bdb7bbc1e0 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 20 Apr 2017 20:24:19 +0200 Subject: [PATCH] src: remove TODO about uv errno removal This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: https://github.com/nodejs/node/pull/12536 Ref: https://github.com/nodejs/node/issues/4641 Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen Reviewed-By: James M Snell --- src/node.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/node.cc b/src/node.cc index 3190d371f5ad04..1093caeed7c131 100644 --- a/src/node.cc +++ b/src/node.cc @@ -892,8 +892,6 @@ Local UVException(Isolate* isolate, Local e = Exception::Error(js_msg)->ToObject(isolate); - // TODO(piscisaureus) errno should probably go; the user has no way of - // knowing which uv errno value maps to which error. e->Set(env->errno_string(), Integer::New(isolate, errorno)); e->Set(env->code_string(), js_code); e->Set(env->syscall_string(), js_syscall);