From 465f75b58a052ded5eabc13e4c2b630abf3a06b6 Mon Sep 17 00:00:00 2001 From: Chengzhong Wu Date: Fri, 17 Nov 2023 11:55:33 +0800 Subject: [PATCH] build: disable flag v8_scriptormodule_legacy_lifetime MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Usages of `v8::ScriptOrModule` were removed in https://github.com/nodejs/node/pull/44198 so the flag can be disabled by default. PR-URL: https://github.com/nodejs/node/pull/50616 Reviewed-By: Michaƫl Zasso Reviewed-By: Richard Lau --- tools/v8_gypfiles/features.gypi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/v8_gypfiles/features.gypi b/tools/v8_gypfiles/features.gypi index aa946a2774177f..b5738243363182 100644 --- a/tools/v8_gypfiles/features.gypi +++ b/tools/v8_gypfiles/features.gypi @@ -270,7 +270,7 @@ # Enable global allocation site tracking. 'v8_allocation_site_tracking%': 1, - 'v8_scriptormodule_legacy_lifetime%': 1, + 'v8_scriptormodule_legacy_lifetime%': 0, # Change code emission and runtime features to be CET shadow-stack compliant # (incomplete and experimental).