From 422b6e8b9fe1adca1539f69eec8eae3aac8c538a Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 24 Apr 2018 14:20:31 -0700 Subject: [PATCH] tools: show stdout/stderr for timed out tests When a test times out, the contents of stdout and stderr can often be highly valuable in debugging. Provide that information. Refs: https://github.com/nodejs/node/issues/19906#issuecomment-382073888 PR-URL: https://github.com/nodejs/node/pull/20260 Reviewed-By: Ruben Bridgewater Reviewed-By: Richard Lau Reviewed-By: Michael Dawson Reviewed-By: Joyee Cheung Reviewed-By: Trivikram Kamat Reviewed-By: Gus Caplan Reviewed-By: Colin Ihrig Reviewed-By: Refael Ackermann --- tools/test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/test.py b/tools/test.py index 62457ec0717a6f..3b420b7a8a0d0a 100755 --- a/tools/test.py +++ b/tools/test.py @@ -333,7 +333,7 @@ def HasRun(self, output): (total_seconds, duration.microseconds / 1000)) if self.severity is not 'ok' or self.traceback is not '': if output.HasTimedOut(): - self.traceback = 'timeout' + self.traceback = 'timeout\n' + output.output.stdout + output.output.stderr self._printDiagnostic() logger.info(' ...')