From 41e2bb185d346b302f3128b269fdaceccc9e0ad2 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Sat, 16 Dec 2017 01:29:19 -0200 Subject: [PATCH] console: make variables and checks stricter PR-URL: https://github.com/nodejs/node/pull/17707 Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- lib/console.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/console.js b/lib/console.js index 8480ccfd468c47..654b5b8280e930 100644 --- a/lib/console.js +++ b/lib/console.js @@ -52,7 +52,7 @@ function Console(stdout, stderr, ignoreErrors = true) { Object.defineProperty(this, '_stdout', prop); prop.value = stderr; Object.defineProperty(this, '_stderr', prop); - prop.value = ignoreErrors; + prop.value = Boolean(ignoreErrors); Object.defineProperty(this, '_ignoreErrors', prop); prop.value = new Map(); Object.defineProperty(this, '_times', prop); @@ -80,7 +80,7 @@ function createWriteErrorHandler(stream) { // This conditional evaluates to true if and only if there was an error // that was not already emitted (which happens when the _write callback // is invoked asynchronously). - if (err && !stream._writableState.errorEmitted) { + if (err !== null && !stream._writableState.errorEmitted) { // If there was an error, it will be emitted on `stream` as // an `error` event. Adding a `once` listener will keep that error // from becoming an uncaught exception, but since the handler is @@ -102,7 +102,7 @@ function write(ignoreErrors, stream, string, errorhandler, groupIndent) { } string += '\n'; - if (!ignoreErrors) return stream.write(string); + if (ignoreErrors === false) return stream.write(string); // There may be an error occurring synchronously (e.g. for files or TTYs // on POSIX systems) or asynchronously (e.g. pipes on POSIX systems), so