From 366c9831cd588e7e51dad2b124a4b5174b3e915e Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 14 Jun 2019 23:06:13 -0400 Subject: [PATCH] build: fix cctest target for --without-report Conditionally build `test/cctest/test_report_util.cc` only when configured to include the diagnostic report feature. PR-URL: https://github.com/nodejs/node/pull/28238 Reviewed-By: Rich Trott Reviewed-By: Ruben Bridgewater --- node.gyp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/node.gyp b/node.gyp index 56377d6a0c5e8e..77ef85c784df04 100644 --- a/node.gyp +++ b/node.gyp @@ -1096,7 +1096,6 @@ 'test/cctest/test_linked_binding.cc', 'test/cctest/test_per_process.cc', 'test/cctest/test_platform.cc', - 'test/cctest/test_report_util.cc', 'test/cctest/test_traced_value.cc', 'test/cctest/test_util.cc', 'test/cctest/test_url.cc', @@ -1134,6 +1133,9 @@ }, }], [ 'node_report=="true"', { + 'sources': [ + 'test/cctest/test_report_util.cc', + ], 'defines': [ 'NODE_REPORT', 'NODE_ARCH="<(target_arch)"',