From 1c314f5facb98e4790ff60f0104f5d18bc3eb53e Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 15 Jun 2017 14:36:39 +0200 Subject: [PATCH] src: don't set --icu_case_mapping flag on startup It's on by default now and the flag will be removed in the near future. Fixes: https://github.com/nodejs/node/issues/13688 PR-URL: https://github.com/nodejs/node/pull/13698 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Colin Ihrig Reviewed-By: Daijiro Wachi Reviewed-By: James M Snell Reviewed-By: Refael Ackermann --- src/node.cc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/node.cc b/src/node.cc index 25a5f2c2754cbc..beeebe6923a18e 100644 --- a/src/node.cc +++ b/src/node.cc @@ -4305,14 +4305,6 @@ void Init(int* argc, // Make inherited handles noninheritable. uv_disable_stdio_inheritance(); -#if defined(NODE_HAVE_I18N_SUPPORT) - // Set the ICU casing flag early - // so the user can disable a flag --foo at run-time by passing - // --no_foo from the command line. - const char icu_case_mapping[] = "--icu_case_mapping"; - V8::SetFlagsFromString(icu_case_mapping, sizeof(icu_case_mapping) - 1); -#endif - #if defined(NODE_V8_OPTIONS) // Should come before the call to V8::SetFlagsFromCommandLine() // so the user can disable a flag --foo at run-time by passing