inspector: implement inspector for chakrashim

Basic implementation of inspector for chakrashim using the v8_inspector code as a basis. It supports mainline debugging scenarios using VS Code and Chrome. PR-URL: #210 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
nodejs · Apr 28, 2017 · a043cb8 · a043cb8
1 parent 3d40cc1
commit a043cb8
Show file tree

Hide file tree

Showing 107 changed files with 4,270 additions and 9,649 deletions.
diff --git a/configure b/configure
@@ -1298,17 +1298,14 @@ def configure_intl(o):
 
 def configure_inspector(o):
   disable_inspector = (options.without_inspector or
-                       options.with_intl in (None, 'none') or
                        options.without_ssl)
   o['variables']['v8_enable_inspector'] = 0 if disable_inspector else 1
 
 def configure_engine(o):
   engine = options.engine.lower()
   o['variables']['node_engine'] = engine
   if engine != 'v8':
-    o['variables']['node_use_v8_platform'] = b(False)
     o['variables']['node_use_bundled_v8'] = b(False)
-    o['variables']['v8_inspector'] = b(False)
     o['variables']['v8_enable_i18n_support'] = 0
 
 output = {

diff --git a/deps/chakrashim/chakrashim.gyp b/deps/chakrashim/chakrashim.gyp
@@ -2,7 +2,8 @@
   'variables': {
     'library_files': [
       'lib/chakra_shim.js',
-      'lib/chakra_debug.js'
+      'lib/chakra_debug.js',
+      'lib/chakra_inspector.js'
     ],
   },
 
@@ -16,6 +17,7 @@
       ],
 
       'include_dirs': [
+        '.',
         'include',
         '<(SHARED_INTERMEDIATE_DIR)',
         './../uv/include'
@@ -80,14 +82,25 @@
         'include/v8-platform.h',
         'include/v8-profiler.h',
         'include/v8-version.h',
+        'src/base/logging.cc',
+        'src/base/logging.h',
+        'src/base/macros.h',
+        'src/base/platform/platform.cc',
+        'src/base/platform/platform.h',
         'src/jsrtcachedpropertyidref.inc',
         'src/jsrtcontextcachedobj.inc',
         'src/jsrtcontextshim.cc',
         'src/jsrtcontextshim.h',
         'src/jsrtdebug.cc',
         'src/jsrtdebug.h',
+        'src/jsrtinspector.cc',
+        'src/jsrtinspector.h',
+        'src/jsrtinspectorhelpers.cc',
+        'src/jsrtinspectorhelpers.h',
         'src/jsrtisolateshim.cc',
         'src/jsrtisolateshim.h',
+        'src/jsrtplatform.cc',
+        'src/jsrtplatform.h',
         'src/jsrtpromise.cc',
         'src/jsrtproxyutils.cc',
         'src/jsrtproxyutils.h',
@@ -111,23 +124,30 @@
         'src/v8int32.cc',
         'src/v8integer.cc',
         'src/v8isolate.cc',
+        'src/v8map.cc',
         'src/v8message.cc',
+        'src/v8microtasksscope.cc',
+        'src/v8name.cc',
         'src/v8number.cc',
         'src/v8numberobject.cc',
         'src/v8object.cc',
         'src/v8objecttemplate.cc',
         'src/v8persistent.cc',
+        'src/v8persistent.cc',
         'src/v8private.cc',
         'src/v8promise.cc',
         'src/v8propertydescriptor.cc',
         'src/v8proxy.cc',
+        'src/v8regexp.cc',
         'src/v8script.cc',
         'src/v8sharedarraybuffer.cc',
+        'src/v8set.cc',
         'src/v8signature.cc',
         'src/v8stacktrace.cc',
         'src/v8string.cc',
         'src/v8stringobject.cc',
         'src/v8symbol.cc',
+        'src/v8symbolobject.cc',
         'src/v8template.cc',
         'src/v8trycatch.cc',
         'src/v8typedarray.cc',

diff --git a/deps/chakrashim/include/libplatform/libplatform.h b/deps/chakrashim/include/libplatform/libplatform.h
@@ -34,13 +34,8 @@
 namespace v8 {
 namespace platform {
 
-v8::Platform* CreateDefaultPlatform(int thread_pool_size = 0) {
-  return nullptr;
-}
-
-bool PumpMessageLoop(v8::Platform* platform, v8::Isolate* isolate) {
-  return false;
-}
+v8::Platform* CreateDefaultPlatform(int thread_pool_size = 0);
+bool PumpMessageLoop(v8::Platform* platform, v8::Isolate* isolate);
 
 /**
 * Attempts to set the tracing controller for the given platform.

diff --git a/deps/chakrashim/include/v8-debug.h b/deps/chakrashim/include/v8-debug.h
@@ -91,6 +91,9 @@ class V8_EXPORT Debug {
   static Local<Context> GetDebugContext(Isolate* isolate);
 
   static void EnableDebug();
+  static void EnableInspector();
+
+  static void SetLiveEditEnabled(Isolate* isolate, bool enable);
 };
 
 }  // namespace v8