test: fixed unit test and jslint issues

Fixed some unit test and marked some to FLAKY. Test cases in `test_environment.cc` from cctest are failing because node-chakracore requires the context to be created before `IsolateData` is created. But in test case in `Env` ctor `IsolateData` is getting created first. PR-URL: #236 Reviewed-By: Kyle Farnung <Kyle.Farnung@microsoft.com>
nodejs · May 5, 2017 · 9a7af26 · 9a7af26
1 parent c577509
commit 9a7af26
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 17 deletions.
diff --git a/node.gyp b/node.gyp
@@ -701,6 +701,9 @@
           'include_dirs': [
             'deps/chakrashim' # include/v8_platform.h
           ],
+          'sources!': [
+            'test/cctest/test_environment.cc', # TODO: Enable these test for node-chakracore
+          ]
         }],
         [ 'node_use_dtrace=="true" and OS!="mac" and OS!="linux"', {
           'copies': [{

diff --git a/test/message/core_line_numbers.chakracore.out b/test/message/core_line_numbers.chakracore.out
@@ -8,4 +8,4 @@ RangeError: Invalid input
    at tryModuleLoad (module.js:*)
    at Module._load (module.js:*:*)
    at Module.runMain (module.js:*:*)
-   at run (bootstrap_node.js:*:*)
+   at startup (bootstrap_node.js:*:*)
diff --git a/test/message/eval_messages.chakracore.out b/test/message/eval_messages.chakracore.out
@@ -5,8 +5,6 @@ SyntaxError: 'with' statements are not allowed in strict mode
    at Anonymous function ([eval]-wrapper:*:*)
    at Module.prototype._compile (module.js:*:*)
    at evalScript (bootstrap_node.js:*:*)
-   at Anonymous function (bootstrap_node.js:*:*)
-   at run (bootstrap_node.js:*:*)
    at startup (bootstrap_node.js:*:*)
    at Anonymous function (bootstrap_node.js:*:*)
 42
@@ -18,8 +16,6 @@ Error: hello
    at Anonymous function ([eval]-wrapper:*:*)
    at Module.prototype._compile (module.js:*:*)
    at evalScript (bootstrap_node.js:*:*)
-   at Anonymous function (bootstrap_node.js:*:*)
-   at run (bootstrap_node.js:*:*)
    at startup (bootstrap_node.js:*:*)
    at Anonymous function (bootstrap_node.js:*:*)
 Error: hello
@@ -29,8 +25,6 @@ Error: hello
    at Anonymous function ([eval]-wrapper:*:*)
    at Module.prototype._compile (module.js:*:*)
    at evalScript (bootstrap_node.js:*:*)
-   at Anonymous function (bootstrap_node.js:*:*)
-   at run (bootstrap_node.js:*:*)
    at startup (bootstrap_node.js:*:*)
    at Anonymous function (bootstrap_node.js:*:*)
 100
@@ -41,8 +35,6 @@ ReferenceError: Variable undefined in strict mode
    at Anonymous function ([eval]-wrapper:*:*)
    at Module.prototype._compile (module.js:*:*)
    at evalScript (bootstrap_node.js:*:*)
-   at Anonymous function (bootstrap_node.js:*:*)
-   at run (bootstrap_node.js:*:*)
    at startup (bootstrap_node.js:*:*)
    at Anonymous function (bootstrap_node.js:*:*)
 10

diff --git a/test/message/nexttick_throw.chakracore.out b/test/message/nexttick_throw.chakracore.out
@@ -3,6 +3,5 @@ ReferenceError: 'undefined_reference_error_maker' is undefined
    at _combinedTickCallback (internal/process/next_tick.js:*:*)
    at _tickCallback (internal/process/next_tick.js:*:*)
    at Module.runMain (module.js:*:*)
-   at run (bootstrap_node.js:*:*)
    at startup (bootstrap_node.js:*:*)
    at Anonymous function (bootstrap_node.js:*:*)
diff --git a/test/message/vm_display_syntax_error.chakracore.out b/test/message/vm_display_syntax_error.chakracore.out
@@ -9,7 +9,7 @@ SyntaxError: Expected identifier
    at tryModuleLoad (module.js:*)
    at Module._load (module.js:*)
    at Module.runMain (module.js:*)
-   at run (bootstrap_node.js:*)
+   at startup (bootstrap_node.js:*)
 SyntaxError: Expected identifier
    at createScript (vm.js:*)
    at runInThisContext (vm.js:*)
@@ -20,4 +20,4 @@ SyntaxError: Expected identifier
    at tryModuleLoad (module.js:*)
    at Module._load (module.js:*)
    at Module.runMain (module.js:*)
-   at run (bootstrap_node.js:*)
+   at startup (bootstrap_node.js:*)
diff --git a/test/message/vm_dont_display_syntax_error.chakracore.out b/test/message/vm_dont_display_syntax_error.chakracore.out
@@ -10,4 +10,4 @@ SyntaxError: Expected identifier
    at tryModuleLoad (module.js:*)
    at Module._load (module.js:*)
    at Module.runMain (module.js:*)
-   at run (bootstrap_node.js:*)
+   at startup (bootstrap_node.js:*)
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -82,6 +82,10 @@ test-whatwg-url-origin-for : SKIP
 test-assert-checktag : SKIP
 test-process-env-symbols : SKIP
 test-module-loading-globalpaths : SKIP
+test-buffer-bindingobj-no-zerofill : PASS,FLAKY
+test-regress-GH-12371 : PASS,FLAKY
+test-util : PASS,FLAKY
+test-zlib-convenience-methods : PASS,FLAKY
 
 [$jsEngine==chakracore && $arch==x64]
 test-buffer-includes : SKIP

diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
@@ -53,10 +53,13 @@ expect('--v8-pool-size=10', 'B\n');
 expect('--use-openssl-ca', 'B\n');
 expect('--use-bundled-ca', 'B\n');
 expect('--openssl-config=_ossl_cfg', 'B\n');
-expect('--icu-data-dir=_d', 'B\n');
 
-    // V8 options
-expect('--max_old_space_size=0', 'B\n');
+if (!common.isChakraEngine) {
+  expect('--icu-data-dir=_d', 'B\n');
+
+  // V8 options
+  expect('--max_old_space_size=0', 'B\n');
+}
 
 function expect(opt, want) {
   const printB = require.resolve('../fixtures/printB.js');

diff --git a/test/parallel/test-process-versions.js b/test/parallel/test-process-versions.js
@@ -27,5 +27,6 @@ assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.http_parser));
 assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.node));
 assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.uv));
 assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.zlib));
-assert(/^\d+\.\d+\.\d+(\.\d+)?$/.test(process.versions.v8));
+assert(/^\d+\.\d+\.\d+(\.\d+)?$/.test(
+  process.versions[process.jsEngine || 'v8']));
 assert(/^\d+$/.test(process.versions.modules));