From 5bd7d4d626015fc47de5e5f7e7e28e35b7a2cc65 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Reis?= Date: Mon, 17 Apr 2017 18:44:50 +0100 Subject: [PATCH] chakrashim: enable building with Node ICU on Linux PR-URL: https://github.com/nodejs/node-chakracore/pull/215 Reviewed-By: Hitesh Kanwathirtha Reviewed-By: Oguz Bastemur --- deps/chakrashim/chakracore.gyp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/deps/chakrashim/chakracore.gyp b/deps/chakrashim/chakracore.gyp index 7a5d7a98ead..9afdaade91a 100644 --- a/deps/chakrashim/chakracore.gyp +++ b/deps/chakrashim/chakracore.gyp @@ -22,7 +22,7 @@ 'msvs_windows_target_platform_version_prop': '/p:WindowsTargetPlatformVersion=$(WindowsTargetPlatformVersion)', }], - ['OS=="mac"', { + ['OS!="win"', { 'icu_include_path': '../<(icu_path)/source/common' }], @@ -42,7 +42,7 @@ 'type': 'none', 'conditions': [ - ['OS=="mac"', { + ['OS!="win"', { 'dependencies': [ '<(icu_gyp_path):icui18n', '<(icu_gyp_path):icuuc', @@ -78,11 +78,11 @@ 'chakracore_binaries': [ '<(chakra_libs_absolute)/lib/libChakraCoreStatic.a', ], + 'icu_args': '--icu=<(icu_include_path)', 'linker_start_group': '-Wl,--start-group', 'linker_end_group': [ '-Wl,--end-group', '-lgcc_s', - '-licuuc', ] }], ['OS=="mac"', {