From 27699e194137482515b0b47cbea74cec8e239c9a Mon Sep 17 00:00:00 2001 From: Oguz Bastemur Date: Fri, 2 Feb 2018 03:06:53 -0800 Subject: [PATCH] deps: update ChakraCore to Microsoft/ChakraCore@59f853017f [1.8>1.9] [MERGE #4611 @obastemur] clang 6.0 support Merge pull request #4611 from obastemur:clang_6_18 Fixes couple of tiny issues we had with upcoming clang 6.0 release Reviewed-By: chakrabot --- deps/chakrashim/core/CMakeLists.txt | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/deps/chakrashim/core/CMakeLists.txt b/deps/chakrashim/core/CMakeLists.txt index 45d1f5ac61b..cc05a551700 100644 --- a/deps/chakrashim/core/CMakeLists.txt +++ b/deps/chakrashim/core/CMakeLists.txt @@ -322,13 +322,24 @@ if(CLR_CMAKE_PLATFORM_XPLAT) -Wno-return-type\ -Wno-switch\ -Wno-implicit-function-declaration\ - -Wno-int-to-pointer-cast" + -Wno-int-to-pointer-cast\ + -Wno-tautological-constant-compare\ + -Wno-enum-compare-switch\ + -Wno-unknown-warning-option" ) # notes.. # -Wno-address-of-temporary # vtinfo.h, VirtualTableInfo::RegisterVirtualTable # -Wno-null-conversion # Check shmemory.cpp and cs.cpp here... # -Wno-return-type # switch unreachable code # -Wno-switch # switch values not handled + # -W-enum-compare-switch # throws warning on enum1 == enum2 where both + # enums represent same value but do not share the type. ie. we use both AsmJsType + # and AsmJsRetType interchangably and filter things out by `default:` case. + # -W-tautological-constant-compare throws warning for checks known at compile time. + # Some of those checks are optimized out during compile / lto time, and others + # are platform / compiler dependent. + # -Wno-unknown-warning-option ... well, some of the new switches are not + # recognized by older compilers and they fail. So, put this one and not fail include(Build/CMakeFeatureDetect.cmake)