Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
lib,src,test: fixing lint errors
Browse files Browse the repository at this point in the history
PR-URL: #454
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
  • Loading branch information
kfarnung committed Jan 26, 2018
1 parent 822d967 commit 1753873
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 11 deletions.
4 changes: 2 additions & 2 deletions lib/internal/bootstrap_node.js
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,8 @@
if (exceptionHandlerState.captureFn !== null) {
exceptionHandlerState.captureFn(er);
} else if (!process.emit('uncaughtException', er)) {
//ENABLE_TTD
NativeModule.require('trace_mgr').onUncaughtExceptionHandler();
//ENABLE_TTD
NativeModule.require('trace_mgr').onUncaughtExceptionHandler();

// If someone handled it, then great. otherwise, die in C++ land
// since that means that we'll exit the process, emit the 'exit' event
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/process.js
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ function setupSignalHandlers() {
process.emit('SIGINT');
};

const signum = constants['SIGINT'];
const signum = constants.SIGINT;
const err = wrap.start(signum);
if (err) {
wrap.close();
Expand Down
6 changes: 3 additions & 3 deletions lib/trace_mgr.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,11 @@ function updateGlobalSampleStats(eventKind) {
currentSampleRate[eventKind] *= emitOptions.backoffFactors[eventKind];

var updateTime = new Date();
emitMinTimeValue['emitOnLogWarn'] = new Date(updateTime);
emitMinTimeValue['emitOnLogError'] = new Date(updateTime);
emitMinTimeValue.emitOnLogWarn = new Date(updateTime);
emitMinTimeValue.emitOnLogError = new Date(updateTime);

if (eventKind === 'emitOnAssert') {
emitMinTimeValue['emitOnAssert'] = updateTime;
emitMinTimeValue.emitOnAssert = updateTime;
}
}

Expand Down
1 change: 0 additions & 1 deletion src/node_file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ namespace node {
void FillStatsArray(v8::Local<v8::Float64Array> fields_array,
const uv_stat_t* s,
int offset) {

Local<v8::ArrayBuffer> ab = fields_array->Buffer();
double* fields = static_cast<double*>(ab->GetContents().Data()) + offset;

Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-uv-binding-constant.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ keys.forEach((key) => {
if (key.startsWith('UV_')) {
const val = uv[key];
assert.throws(() => uv[key] = 1,
common.engineSpecificMessage({
v8: /^TypeError: Cannot assign to read only property/,
chakracore: /^TypeError: Assignment to read-only properties is not allowed in strict mode$/
})
common.engineSpecificMessage({
v8: /^TypeError: Cannot assign to read only property/,
chakracore: /^TypeError: Assignment to read-only properties is not allowed in strict mode$/
})
);
assert.strictEqual(uv[key], val);
}
Expand Down

0 comments on commit 1753873

Please sign in to comment.