Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-mortem test suite #37

Closed
gibfahn opened this issue Oct 17, 2016 · 6 comments
Closed

Post-mortem test suite #37

gibfahn opened this issue Oct 17, 2016 · 6 comments

Comments

@gibfahn
Copy link
Member

gibfahn commented Oct 17, 2016

I'd like to set up tests running llnode against coredumps. I've noticed that the current suite only tests attaching to a running process, and I'd like to extend it to run the same tests on an aborted process (I think the simplest method would be to run with --abort-on-uncaught-exception and then run the existing suite on the dump).

Does anyone have any views on how this should look (or how this should be implemented)?

@rnchamberlain
Copy link
Contributor

+1 for this, I would suggest testing core dumps from segv crash and out of memory scenarios as well as uncaught exception.

@indutny
Copy link
Member

indutny commented Oct 18, 2016

Sounds interesting indeed!

It'll most likely require a custom CI infrastructure with the core dumps enabled. cc @nodejs/jenkins-admins and @thealphanerd maybe?

@indutny
Copy link
Member

indutny commented Nov 23, 2016

We have one test case that checks core dumps on OS X at the moment. It would be great to have something broader for other unixes too.

@bnoordhuis
Copy link
Member

@gibfahn Are you still working on this?

@gibfahn
Copy link
Member Author

gibfahn commented Jun 30, 2017

@gibfahn Are you still working on this?

First step is getting tests in CI with nodejs/build#777.

@mmarchini
Copy link
Contributor

Testing on TravisCI is working, and the Build WG is working to create a llnode job on Jenkins (nodejs/build#1025). Since we have a llnode test suite working right now and there's a tracking issue to create the Jenkins job, I'll close this, but feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants