From 95ec68a347b6475f25aea748e292b3095d3383fa Mon Sep 17 00:00:00 2001
From: Phillip Johnsen <johphi@gmail.com>
Date: Thu, 28 Apr 2016 21:12:20 +0200
Subject: [PATCH] Fix for bad node core PR exclusive labels.

This fixes some bad labelling by ensuring that *every* file affected in
the PR actually matches an exclusive label when we're checking for exclusive labels.

Refs https://github.com/nodejs/node/pull/6448 https://github.com/nodejs/node/pull/6432
Closes https://github.com/nodejs-github-bot/github-bot/issues/33
---
 lib/node-labels.js       |  7 ++++++-
 test/node-labels.test.js | 14 ++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/lib/node-labels.js b/lib/node-labels.js
index b1a128c0..ec0305e1 100644
--- a/lib/node-labels.js
+++ b/lib/node-labels.js
@@ -25,8 +25,9 @@ function resolveLabels (filepathsChanged) {
 }
 
 function matchExclusiveSubSystem (filepathsChanged) {
+  const isExclusive = filepathsChanged.every(matchesAnExclusiveLabel)
   const labels = matchSubSystemsByRegex(exclusiveLabelsMap, filepathsChanged)
-  return labels.length === 1 ? labels : []
+  return (isExclusive && labels.length === 1) ? labels : []
 }
 
 function matchAllSubSystem (filepathsChanged) {
@@ -75,4 +76,8 @@ function withoutUndefinedValues (label) {
   return label !== undefined
 }
 
+function matchesAnExclusiveLabel (filepath) {
+  return mappedSubSystemForFile(exclusiveLabelsMap, filepath) !== undefined
+}
+
 exports.resolveLabels = resolveLabels
diff --git a/test/node-labels.test.js b/test/node-labels.test.js
index ce8ab1a9..5b220265 100644
--- a/test/node-labels.test.js
+++ b/test/node-labels.test.js
@@ -27,6 +27,20 @@ tap.test('no labels: when ./test/ and ./doc/ files has been changed', (t) => {
   t.end()
 })
 
+// This ensures older mislabelling issues doesn't happen again
+// https://github.com/nodejs/node/pull/6432
+// https://github.com/nodejs/node/pull/6448
+tap.test('no labels: when ./test/ and ./lib/ files has been changed', (t) => {
+  const labels = nodeLabels.resolveLabels([
+    'lib/assert.js',
+    'test/parallel/test-assert.js'
+  ])
+
+  t.same(labels, [])
+
+  t.end()
+})
+
 tap.test('label: "doc" when only ./doc/ files has been changed', (t) => {
   const labels = nodeLabels.resolveLabels([
     'doc/api/fs.md',