Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -a append option to citgm-all #193

Closed
gdams opened this issue Oct 6, 2016 · 3 comments
Closed

add -a append option to citgm-all #193

gdams opened this issue Oct 6, 2016 · 3 comments

Comments

@gdams
Copy link
Member

gdams commented Oct 6, 2016

When we run our citgm tests we pre-create a tap file with useful meta data in about the jenkins job (etc). The problem with citgm is that it overwrites this file. However easy it would be to just append this data afterwards, it would be useful if we could just tell citgm-all that we want to append using -a or something

@MylesBorins
Copy link
Contributor

@GeorgeAdams95 I think that this could be done by alternating between readFileSync and appendFileSync in the reporter

Would you be interested in submitting a Pull Request?

This does bring up some interesting problems with our current logging set up. I have discussed with @bengl before about a major refactor of the logging in CITGM, perhaps this is a bigger project you might be interested in.

@gdams
Copy link
Member Author

gdams commented Oct 11, 2016

Yes i'm happy to put together a pull request. I was speaking with @gibfahn about whether we could find a way to append to a tap file test-by-test rather than as one batch at the end but obviously this would be something more major. But yeah, I would be interested in a project like that

@gdams
Copy link
Member Author

gdams commented Nov 7, 2016

landed in 640556b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants