Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-stress-single-test: timeouts and/or run durations? #260

Closed
Trott opened this issue Nov 18, 2015 · 3 comments
Closed

node-stress-single-test: timeouts and/or run durations? #260

Trott opened this issue Nov 18, 2015 · 3 comments

Comments

@Trott
Copy link
Member

Trott commented Nov 18, 2015

For nodejs/node#3881, I'm trying to run a test only about 100 times to get a baseline failure rate. The test fails by timing out on CI a lot so 100 seemed like enough times to see a good number of failures on a Pi. It's taken hours and only gotten through the test 70 times or so with no failures at all. This leads me to believe that timeouts for all tests are not enforced on the stress tests the way they are for node-test-commit.

OK, no problem, I'll look and see how long each test run took! But that's not printed for the stress tests the way it is for node-test-commit.

This is not exactly urgent as there are some simple hacks/workarounds I can do for this, but in the interest of making the node-stress-single-test as useful as possible, can we at least get a duration printed for individual test runs, if not timeouts identical to what is enforced in the other node-test-commit?

cc: @joaocgreis

@joaocgreis
Copy link
Member

Tests in node-stress-single-test are run directly with node, without using test.py. Hence timeouts are not enforced at all. I just changed it to print the approximate duration of the test, that was easy to do.

To do this properly, however, would be to change test.py to run some test a number of times, optionally running all other tests as it does now or skipping them. I'll keep this in my work list, but don't have the time right now. Perhaps this is a good first task for the testing WG? Ping me if you need more changes in the jenkins job, that I can do fairly quickly.

@jbergstroem
Copy link
Member

fwiw, I saw a pretty long running test on the rpi's (3500 iterations done after ~6 hours) the other day.

@rvagg
Copy link
Member

rvagg commented Nov 22, 2015

I killed one that was about that many iterations yesterday cause it was the only thing holding up a jenkins restart

@Trott Trott closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants