Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we unlabel backport-requested-v7.x PRs now? #226

Closed
sam-github opened this issue Jun 5, 2017 · 6 comments
Closed

should we unlabel backport-requested-v7.x PRs now? #226

sam-github opened this issue Jun 5, 2017 · 6 comments

Comments

@sam-github
Copy link
Contributor

sam-github commented Jun 5, 2017

At least one person backported a PR to 7.x because they saw the label, but they wasted their time, we aren't rereleasing 7.x, EDIT: nodejs/node#13436 (comment) was the issue that made me thing this may be a problem.

I went through the first 6 or 8 PRs in https://github.com/nodejs/node/issues?q=label%3Abackport-requested-v7.x, and AFAICT they are all in 8.x, so I removed the label.

I can keep going, but I don't think its necessary. If any PRs are missing from 8.x, that will be dealt with by the 8.x release team, so I think we can uniformly unlabel all the issues with backport-requested-v7.x to prevent anyone wasting their time trying to backport.

Agreed, @nodejs/lts?

@jasnell
Copy link
Member

jasnell commented Jun 5, 2017

It's still possible that we could do a 7.x release sometime this month... not likely but possible. I'd suggest waiting until the end of June

@sam-github
Copy link
Contributor Author

We might, but we would only include really critical bug fixes in it, right? Whereas the things still labelled backport-requested-7.x were clearly not that important, or they would have been backported already.

I'm just trying to avoid any more people wasting their time: nodejs/node#13436 (comment)

@gibfahn
Copy link
Member

gibfahn commented Jun 5, 2017

+1 to removing it from existing PRs. If any of them were urgent enough to trigger a v7.x release that would already have happened. If something urgent comes up and we have to do a v7.x release, we can tag that PR then (we don't have to delete the tag).

Put it another way, if we do another v7.x release, is there any reason to backport these 32 PRs to it?

@mhdawson
Copy link
Member

mhdawson commented Jun 6, 2017

I think we should either remove (my first choice) or it we leave it on maybe add a comment explaining the situation so people don't do unnecessary work. I would not be happy if I did a backport only to be told it was not going to be accepted.

@gibfahn
Copy link
Member

gibfahn commented Jun 14, 2017

I think this can be closed as agreed (if anyone has an issue with this feel free to reopen).

@gibfahn
Copy link
Member

gibfahn commented Jun 14, 2017

Unlabelled everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants