Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and
Proposed changes
This PR fixes a trivial bug and implements the new image attachment feature of the pushover API.
Bugfix
There is a small bug in the event handler passed to the
input
event on line 32. Inside the event handler function, it makes references tothis
intended for the outer scope (not the new functional scope within the handler).New Feature
The image attachment feature looks for an
attachment
property in the NR message payload. This property can hold a local file path, or a Buffer (binary or base64 encoded) representing an image to be sent along with the message to the Pushover API server.Checklist
grunt
to verify the unit tests passThere are currently no existing unit tests for this node. I have discussed this with @dceejay who has agreed to review the PR without unit tests.