Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for images in pushover node #458

Closed
tve opened this issue Jun 29, 2018 · 6 comments
Closed

Add support for images in pushover node #458

tve opened this issue Jun 29, 2018 · 6 comments

Comments

@tve
Copy link

tve commented Jun 29, 2018

Which node are you reporting an issue on?

node-red-node-pushover

What are the steps to reproduce?

Please add support for pushing images. Perhaps see https://github.com/RayPS/node-red-contrib-pushover ?

@knolleary
Copy link
Member

knolleary commented Jun 29, 2018

From the issue template you were shown when raising:

If your issue is:

  • a general 'how-to' type question,
  • a feature request or suggestion for a change,
  • or problems with 3rd party (node-red-contrib-) nodes

please use the Node-RED Forum or slack team.

@knolleary
Copy link
Member

If there is a contrib node that already provides this functionality then why not use that one?

@tve
Copy link
Author

tve commented Jun 30, 2018

I guess so. I was disappointed that the built-in node I was using doesn't support the newer features. Dunno what your policy is, perhaps it's "built-in nodes provide minimal functionality, always look first for a good contrib node"?

@dceejay
Copy link
Member

dceejay commented Jun 30, 2018

Our policy is to encourage people to offer pull requests for enhancements to nodes rather than fork them.. But we can't and won't stop them forking if they wish to. We do try to maintain the non-core nodes, but don't use them every day, so rely on the community to offer updates.

@dceejay
Copy link
Member

dceejay commented Aug 17, 2018

html support was recently added - does that help cover this ?

@tve
Copy link
Author

tve commented May 30, 2019

Implemented in #509, thanks!

@tve tve closed this as completed May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants