Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would activeReporters = Collections.singletonList(REPORTER); can reporter be unique to each class rather than one report for all.. #93

Open
nagkumar opened this issue Jun 10, 2023 · 2 comments

Comments

@nagkumar
Copy link

nagkumar commented Jun 10, 2023

public final class JUnitPerfInterceptorSuite extends JUnitPerfInterceptor
{
    private static final HtmlReportGenerator REPORTER = newHtmlReporter("suite_reporter.html");
    private static final DescriptiveStatisticsCalculator statisticsCalculator = new DescriptiveStatisticsCalculator();

    @Override
    public void postProcessTestInstance(Object testInstance, ExtensionContext context) throws Exception
    {
	activeReporters = Collections.singletonList(REPORTER);
	activeStatisticsCalculator = statisticsCalculator;

	defaultRequirementsAnnotation = new JUnitPerfTestRequireme

Also, as active report is always the same as it is now..

why is it needed to call this once per each test

activeReporters = Collections.singletonList(REPORTER);

@nagkumar
Copy link
Author

Would you also consider not to have separate report that is parallel to unit test report, is it possible to include perf metrics within existing junit report

I definitely like this

@nagkumar
Copy link
Author

would consider not to change existing JUnit report with another file names etc..

can you consider to hook perf info within the existing junit report

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant