From cd722b670f5721f36e326841db76f2b895f77d88 Mon Sep 17 00:00:00 2001 From: Margret Riegert Date: Thu, 19 Dec 2024 17:28:19 -0500 Subject: [PATCH] Fix bug where private/protected methods were hidden in a class nested in a :showdoc: class --- src/compiler/crystal/tools/doc/generator.cr | 10 ---------- src/compiler/crystal/tools/doc/type.cr | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/compiler/crystal/tools/doc/generator.cr b/src/compiler/crystal/tools/doc/generator.cr index e57120d3e118..738cbf4b7f47 100644 --- a/src/compiler/crystal/tools/doc/generator.cr +++ b/src/compiler/crystal/tools/doc/generator.cr @@ -236,16 +236,6 @@ class Crystal::Doc::Generator false end - def showdoc?(obj) - return false if !@program.wants_doc? - - if showdoc?(obj.doc.try &.strip) - return true - end - - false - end - def crystal_builtin?(type) return false unless project_info.crystal_stdlib? # TODO: Enabling this allows links to `NoReturn` to work, but has two `NoReturn`s show up in the sidebar diff --git a/src/compiler/crystal/tools/doc/type.cr b/src/compiler/crystal/tools/doc/type.cr index 546a961856ee..6588a3932b0c 100644 --- a/src/compiler/crystal/tools/doc/type.cr +++ b/src/compiler/crystal/tools/doc/type.cr @@ -267,7 +267,7 @@ class Crystal::Doc::Type end private def showdoc?(adef) - @generator.showdoc?(adef.doc.try &.strip) || @generator.showdoc?(self) + @generator.showdoc?(adef.doc.try &.strip) || @generator.showdoc?(@type) end private def sort_order(item)