Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebService-Target fails internally with PlatformNotSupportedException on NetCore #2563

Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 3, 2018

WebRequest.GetSystemWebProxy fails when attempting to use Default-proxy on NetCore

See also https://github.com/dotnet/corefx/issues/7037

Changed default value for ProxyType to be NoProxy on NetCore (Avoid internal exception on every request)

@snakefoot snakefoot force-pushed the WebServiceTargetNetCoreNoProxy branch 2 times, most recently from d699252 to 268a416 Compare February 3, 2018 11:00
@codecov
Copy link

codecov bot commented Feb 3, 2018

Codecov Report

Merging #2563 into master will decrease coverage by <1%.
The diff coverage is 33%.

@@           Coverage Diff           @@
##           master   #2563    +/-   ##
=======================================
- Coverage      82%     81%   -<1%     
=======================================
  Files         323     323            
  Lines       23430   23431     +1     
  Branches     2936    2936            
=======================================
- Hits        19097   19094     -3     
- Misses       3554    3564    +10     
+ Partials      779     773     -6

@snakefoot snakefoot force-pushed the WebServiceTargetNetCoreNoProxy branch 11 times, most recently from f89b238 to 4744736 Compare February 4, 2018 00:19
… when attempting to use Default-proxy on NetCore
@snakefoot snakefoot force-pushed the WebServiceTargetNetCoreNoProxy branch from 4744736 to 6640871 Compare February 4, 2018 00:25
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Feb 5, 2018
@304NotModified
Copy link
Member

thx!

@304NotModified 304NotModified added this to the 4.5 rc5 milestone Feb 5, 2018
@304NotModified 304NotModified merged commit bee90ea into NLog:master Feb 5, 2018
@snakefoot snakefoot deleted the WebServiceTargetNetCoreNoProxy branch April 4, 2020 17:37
@snakefoot snakefoot modified the milestones: 4.5 rc5, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature webservice-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants