Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test possible close before use regression #86

Open
maeb opened this issue Mar 6, 2024 · 2 comments
Open

Test possible close before use regression #86

maeb opened this issue Mar 6, 2024 · 2 comments

Comments

@maeb
Copy link
Member

maeb commented Mar 6, 2024

Commit a72acd4 possibly introduced a close before use issue (maybe nil pointer exception).
@maeb
Copy link
Member Author

maeb commented Mar 6, 2024

We need to test this.

@trym-b
Copy link
Contributor

trym-b commented Mar 7, 2024

This should be pretty straightforward to do:

  1. Create a test that fails
  2. See the test fails
  3. Revert the commit
  4. See the test pass
  5. ???
  6. Profit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maeb @trym-b