Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

node-sass should be update to 3.7.0 #17

Closed
lihuazhang opened this issue Jun 9, 2016 · 1 comment
Closed

node-sass should be update to 3.7.0 #17

lihuazhang opened this issue Jun 9, 2016 · 1 comment

Comments

@lihuazhang
Copy link

lihuazhang commented Jun 9, 2016

node-sass should be update to 3.7.0, or it will throw ObjectTemplate::Set() with non-primitive values is deprecated exception. see sass/node-sass#1484

and when run build, it will throw

> redux-webpack-es6-boilerplate@0.7.1 build /Users/lihuazhang/code/React/redux-demo
> SET NODE_ENV=production & NODE_ENV=production & webpack -p --config ./config/webpack.config.prod.js --progress

sh: SET: command not found

so

diff --git a/package.json b/package.json
index 2a77f87..48c968b 100644
--- a/package.json
+++ b/package.json
@@ -26,7 +26,7 @@
     "prestart": "node ./bin/clean.js",
     "start": "webpack-dev-server --config ./config/webpack.config.dev.js --hot --inline --progress",
     "prebuild": "npm run clean:build && npm run build:html",
-    "build": "SET NODE_ENV=production& NODE_ENV=production& webpack -p --config ./config/webpack.config.prod.js --progress",
+    "build": "export NODE_ENV=production & NODE_ENV=production & webpack -p --config ./config/webpack.config.prod.js --progress",
     "lint": "eslint config src/js/** --ext .js",
     "jscs": "jscs src/js/",
     "test": "mocha --compilers js:babel-core/register,css:./test/unit/cssNullCompiler.js --require ./test/unit/testHelper.js --recursive ./test/unit",
@@ -53,7 +53,7 @@
     "jscs": "2.10.1",
     "jsdom": "8.2.0",
     "mocha": "2.4.5",
-    "node-sass": "3.6.0",
+    "node-sass": "3.7.0",
     "postcss-loader": "0.8.2",
     "react-addons-test-utils": "15.0.1",
     "react-hot-loader": "1.3.0",

@nicksp
Copy link
Owner

nicksp commented Jun 15, 2016

@lihuazhang Thanks for you advice. Applied suggested changes. Gives me no errors now.
You can pull latest changes now.

@nicksp nicksp closed this as completed Jun 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants