Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RapidXML #37

Open
nicholas-rh opened this issue Aug 1, 2023 · 1 comment
Open

RapidXML #37

nicholas-rh opened this issue Aug 1, 2023 · 1 comment

Comments

@nicholas-rh
Copy link
Owner

No description provided.

@nicholas-rh
Copy link
Owner Author

This and RapidJSON as well are header only and so it should be very simple to use the system provided version by commenting out the O3DE package for them. The problem is that the O3DE build system will try and fail to search for a CMake find module and return an error when doing this. Ideally this is solvable through using the strategy demonstrated here o3de/3p-package-source#205 where the find module itself is modified. This is difficult to produce patches for, however, and even more difficult to do so in a way that is synced with a fork of O3DE, since each package this is done for needs to be rebuilt and rehosted manually with the find module changes. The best solution would be to have engagement from upstream to help get the PR above and equivalent PRs for other dependencies merged.

@nicholas-rh nicholas-rh mentioned this issue Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant