Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip to main content inconsistencies #716

Closed
mikestreety opened this issue Mar 12, 2021 · 3 comments
Closed

Skip to main content inconsistencies #716

mikestreety opened this issue Mar 12, 2021 · 3 comments
Assignees
@chrimesdev

Comments

@mikestreety
Copy link

mikestreety commented Mar 12, 2021 •
edited
Loading

Bug Report

What is the issue?

There is an inconsistency between the skip link href and ID on the main content within the docs

What steps are required to reproduce the issue?

On the Page Template page the demo content has a - hyphen in the href but on the ID. This occurs in a few places in the docs

image
@chrimesdev chrimesdev mentioned this issue Mar 12, 2021
Merged
4 tasks
@chrimesdev
Copy link
Member

chrimesdev commented Mar 12, 2021 •
edited
Loading

Hey @mikaelmetthey good spot, they should be the same throughout!

I've opened a pull request to fix this on the NHS digital service manual repo, will aim to get this fixed and released for Monday.

Thanks for raising this

@chrimesdev chrimesdev self-assigned this Mar 12, 2021
@mikestreety
Copy link
Author

Thanks for the quick response @AdamChrimes!

@chrimesdev
Copy link
Member

This was released this morning https://service-manual.nhs.uk/design-system/styles/page-template

Thanks again for raising this @mikestreety

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrimesdev chrimesdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikestreety @chrimesdev