Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codelyzer #5

Closed
SamVerschueren opened this issue Sep 26, 2016 · 3 comments
Closed

Add codelyzer #5

SamVerschueren opened this issue Sep 26, 2016 · 3 comments

Comments

@SamVerschueren
Copy link
Collaborator

codelyzer could enforce the Angular2 styleguide. Might be a nice addition to add that.

See ng-be/app-ng-be-org#4 (comment) for the context.

@samvloeberghs
Copy link
Member

@SamVerschueren I've been doing this in the branch "codelyzer" but I have some issue with node_modules being linted, can you take a look please? :)

@SamVerschueren
Copy link
Collaborator Author

@samvloeberghs Do you get the error in compiler.umd.js? It's a very strange error I get.

template.animations.forEach(function (entry) { triggerLookup.add(entry.name); });

I dived into the task where the linting code is being fired, and basically it invokes the linter like this

$ tslint --config tslint.json src/**/*ts

Which is correct and shouldn't include node_modules. So the compiler.umd.js error comes from somewhere else.

I took a look at Google and came here. Issue that tracks this in codelyzer can be found here.

I will submit a PR against the codelyzer branch that removes the rules that can't be used right now.

@samvloeberghs
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants