Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set family name from MUST to SHOULD #15

Closed
HLWeil opened this issue Mar 25, 2024 · 9 comments
Closed

Set family name from MUST to SHOULD #15

HLWeil opened this issue Mar 25, 2024 · 9 comments
Assignees

Comments

@HLWeil
Copy link
Member

HLWeil commented Mar 25, 2024

https://www.quora.com/What-cultures-do-not-use-family-names#:~:text=As%20well%20as%20the%20mentioned,Sometimes%20they%20invent%20a%20surname.

Some bigger culture groups like javanese people from indonesia don't have surnames, so we should not set this field to MUST.

Either use MAY or SHOULD instead.

@floWetzels
Copy link
Collaborator

Sounds reasonable. But how about the first name? Should there be any MUSTs in the person profile other than the ID?

@HLWeil
Copy link
Member Author

HLWeil commented May 8, 2024

Hmm, good question. Probably also cases where an ORCID does suffice. So yeah maybe set it to SHOULD.

@stuzart
Copy link
Collaborator

stuzart commented May 14, 2024

I completely agree about the cultural differences, and shouldn't be a MUST.
Could just replace both with name instead, this is what the draft bioschemas profile recommends: https://bioschemas.org/profiles/Person/0.3-DRAFT

@floWetzels
Copy link
Collaborator

Good catch! So should we say name is a MUST, but familyName and givenName are COULD? Or drop them completely?

@stuzart
Copy link
Collaborator

stuzart commented May 21, 2024

I would say keep name as MUST and drop familyName and givenName

@floWetzels
Copy link
Collaborator

Ok, do you agree, @HLWeil @Freymaurer ?

@HLWeil
Copy link
Member Author

HLWeil commented May 27, 2024

I agree that this would be the most practictal solution with no further constraints. But as we want to depict the ISA model with this profile, I think we should stick to givenName + familyName, but just loosen the restriction of familyName.

@stuzart
Copy link
Collaborator

stuzart commented May 30, 2024

sounds good to me, as you say we're constrained by the ISA model.

@kMutagene kMutagene added the Status: Needs Triage This item is up for investigation. label Jun 18, 2024
@floWetzels
Copy link
Collaborator

Fixed by PR #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants