Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated getAnnotations/setAnnotations usage to help update to Python client >= v4.3.1 #199

Closed
anngvu opened this issue Oct 30, 2024 · 1 comment · Fixed by #202
Closed

Remove deprecated getAnnotations/setAnnotations usage to help update to Python client >= v4.3.1 #199

anngvu opened this issue Oct 30, 2024 · 1 comment · Fixed by #202
Assignees
@anngvu

Comments

@anngvu
Copy link
Contributor

anngvu commented Oct 30, 2024 •
edited
Loading

Usage of these deprecated functions means we've been holding back on moving to new version of the client (though this is possibly not the only issue to resolve). To feel safer moving to the target new version, this is one of the more obvious updates to make.
@anngvu anngvu self-assigned this Oct 30, 2024
@anngvu anngvu changed the title Evaluate and document issues for latest client Python (>= v4.0) Evaluate and update to Python client >= v4.3.1 Nov 5, 2024
@anngvu
Copy link
Contributor Author

anngvu commented Nov 6, 2024

Related to #197, the compatible approach shouldn't use .syn$getAnnotations since it's technically deprecated.

@anngvu anngvu changed the title Evaluate and update to Python client >= v4.3.1 Remove deprecated getAnnotations usage to help update to Python client >= v4.3.1 Nov 14, 2024
@anngvu anngvu changed the title Remove deprecated getAnnotations usage to help update to Python client >= v4.3.1 Remove deprecated getAnnotations/setAnnotations usage to help update to Python client >= v4.3.1 Nov 14, 2024
@anngvu anngvu mentioned this issue Nov 15, 2024
Merged
@anngvu anngvu moved this to Done in NF-OSI Sprints Nov 15, 2024
@anngvu anngvu closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anngvu anngvu

Labels
None yet
Projects
NF-OSI Sprints
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update set annotations usage nf-osi/nfportalutils
1 participant
@anngvu