Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/new cbp mapping #382

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Patch/new cbp mapping #382

merged 4 commits into from
Dec 20, 2023

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Dec 13, 2023

Add supplemental properties that may curated for certain projects, i.e. see https://www.cell.com/stem-cell-reports/fulltext/S2213-6711(19)30002-5?_returnURL=https%3A%2F%2Flinkinghub.elsevier.com%2Fretrieve%2Fpii%2FS2213671119300025%3Fshowall%3Dtrue#tbl1

I expect main reviewers to be Robert or Jineta, but Christina for awareness.

Copy link

Test Suite Report

Template Generation

template result link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

Copy link
Contributor

@cconrad8 cconrad8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me - just curious if this is something we're adding to the regular metadata dictionary (not just cbioportal mapping?)

@anngvu
Copy link
Collaborator Author

anngvu commented Dec 20, 2023

@cconrad8 Yep, nf1GermlineMutation and nf1SomaticMutation are now attributes in the model, just not part of any template yet. There's still an issue out to develop a real clinical data template, which could make use of these.

@anngvu anngvu merged commit aba28fd into main Dec 20, 2023
@anngvu anngvu deleted the patch/new-cbp-mapping branch December 20, 2023 21:49
@cconrad8
Copy link
Contributor

@anngvu gotcha sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants