Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-core download: Handle multiple containers #513

Closed
ewels opened this issue Feb 11, 2020 · 3 comments
Closed

nf-core download: Handle multiple containers #513

ewels opened this issue Feb 11, 2020 · 3 comments
Labels
command line tools Anything to do with the cli interfaces download nf-core download

Comments

@ewels
Copy link
Member

ewels commented Feb 11, 2020

At the moment, if used with --singularity then nf-core download expects there to only be a single container and pulls that. There are however some pipelines that need more than one (sarek, neutronstar and more) and there will be many more (all) in the future.

Need to instead parse all instances of process.container if possible and automatically pull all required singularity images.

Would be good to combine with #464 to also automatically configure the pipeline with paths so that it knows where these containers are out of the box.

@maxulysse
Copy link
Member

Could be an issue if the tag is specified by a parameter:
https://github.com/nf-core/sarek/blob/5c30fd821ab7cdf27fd4105464a1fba5eabdfcd5/conf/base.config#L67-L74
I could rewrite these lines to specify each containers for each genome, but then wouldn't nf-core download try to download all containers?
Then again, Sarek is a very specific case...

@apeltzer
Copy link
Member

Yeah, I fear this is very special behaviour. Most people will (hopefully?) use biocontainers soon when DSLv2 is used more widely, then downloading directly from biocontainers instead...

@ewels
Copy link
Member Author

ewels commented Feb 17, 2021

Much of the download code was rewritten #832 - I think that having special cases like this is beyond the scope of nf-core download so I will close this issue now.

@ewels ewels closed this as completed Feb 17, 2021
@edmundmiller edmundmiller added the download nf-core download label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command line tools Anything to do with the cli interfaces download nf-core download
Projects
None yet
Development

No branches or pull requests

4 participants