Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-core lint no longer respects skipping pipeline name checks #2027

Closed
awgymer opened this issue Nov 17, 2022 · 2 comments
Closed

nf-core lint no longer respects skipping pipeline name checks #2027

awgymer opened this issue Nov 17, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@awgymer
Copy link
Contributor

awgymer commented Nov 17, 2022

Description of the bug

Due to the addition of a check on pipeline name added to PipelineCreate.create_param_dict attempting to lint a pipeline but skip linting the name no longer works as reported by @matthdsm on Slack.

Potential solutions:

  • remove check from method
  • leverage .nf-core.yml to selectively ignore this check.

If we go option 2 then I would propose making tools always attempt to load the .nf-core.yml (we are already possibly expanding where it is needed due to path changes) and store the config in some globally available object that can be easily referred to across the tools code.

Command used and terminal output

nf-core lint

    nf-core/tools version 2.7.dev0 - https://nf-co.re


INFO     Testing pipeline: .                                                                                                                   
Running lint checks ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0 of 18 » files_existERROR    Invalid workflow name: must be lowercase without punctuation.

System information

nf-core/tools 2.7.dev0

@awgymer awgymer added the bug Something isn't working label Nov 17, 2022
@mirpedrol
Copy link
Member

Fixed in #2035

@matthdsm
Copy link
Contributor

Thanks @mirpedrol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants