From b1e8d079a59628d284d053848380c4db612ea5df Mon Sep 17 00:00:00 2001 From: mirpedrol <mirp.julia@gmail.com> Date: Tue, 20 Jun 2023 09:02:23 +0200 Subject: [PATCH] lint for default values null, empty strings or none --- nf_core/schema.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/nf_core/schema.py b/nf_core/schema.py index 75dbebce04..b00697334b 100644 --- a/nf_core/schema.py +++ b/nf_core/schema.py @@ -238,6 +238,11 @@ def validate_default_params(self): jsonschema.validate(self.schema_defaults, schema_no_required) except jsonschema.exceptions.ValidationError as e: raise AssertionError(f"Default parameters are invalid: {e.message}") + for param, default in self.schema_defaults.items(): + if default in ("null", "", None, "None"): + log.warning( + f"[yellow][!] Default parameter '{param}' is empty or null. It is advisable to remove the default from the schema" + ) log.info("[green][✓] Default parameters match schema validation") # Make sure every default parameter exists in the nextflow.config and is of correct type