From b402201076a28094b9a70a654897e4b5e842b34d Mon Sep 17 00:00:00 2001 From: JoseEspinosa Date: Wed, 6 Oct 2021 22:51:43 +0200 Subject: [PATCH 1/2] Update template to fix dumpsoftwareversions --- nf_core/pipeline-template/modules.json | 2 +- .../nf-core/modules/custom/dumpsoftwareversions/main.nf | 2 +- .../nf-core/modules/custom/dumpsoftwareversions/meta.yml | 4 ++-- nf_core/pipeline-template/workflows/pipeline.nf | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/nf_core/pipeline-template/modules.json b/nf_core/pipeline-template/modules.json index a225b686a8..db6aceae73 100644 --- a/nf_core/pipeline-template/modules.json +++ b/nf_core/pipeline-template/modules.json @@ -4,7 +4,7 @@ "repos": { "nf-core/modules": { "custom/dumpsoftwareversions": { - "git_sha": "7b3315591a149609e27914965f858c9a7e071564" + "git_sha": "84f2302920078b0cf7716b2a2e5fcc0be5c4531d" }, "fastqc": { "git_sha": "7b3315591a149609e27914965f858c9a7e071564" diff --git a/nf_core/pipeline-template/modules/nf-core/modules/custom/dumpsoftwareversions/main.nf b/nf_core/pipeline-template/modules/nf-core/modules/custom/dumpsoftwareversions/main.nf index cf10a8e072..faf2073f75 100644 --- a/nf_core/pipeline-template/modules/nf-core/modules/custom/dumpsoftwareversions/main.nf +++ b/nf_core/pipeline-template/modules/nf-core/modules/custom/dumpsoftwareversions/main.nf @@ -79,7 +79,7 @@ process CUSTOM_DUMPSOFTWAREVERSIONS { } with open("$versions") as f: - workflow_versions = yaml.safe_load(f) | module_versions + workflow_versions = yaml.load(f, Loader=yaml.BaseLoader) | module_versions workflow_versions["Workflow"] = { "Nextflow": "$workflow.nextflow.version", diff --git a/nf_core/pipeline-template/modules/nf-core/modules/custom/dumpsoftwareversions/meta.yml b/nf_core/pipeline-template/modules/nf-core/modules/custom/dumpsoftwareversions/meta.yml index 1cf616159c..8d4a6ed42c 100644 --- a/nf_core/pipeline-template/modules/nf-core/modules/custom/dumpsoftwareversions/meta.yml +++ b/nf_core/pipeline-template/modules/nf-core/modules/custom/dumpsoftwareversions/meta.yml @@ -24,9 +24,9 @@ output: type: file description: MultiQC custom content YML file containing software versions pattern: "software_versions_mqc.yml" - - version: + - versions: type: file - description: File containing software version + description: File containing software versions pattern: "versions.yml" authors: diff --git a/nf_core/pipeline-template/workflows/pipeline.nf b/nf_core/pipeline-template/workflows/pipeline.nf index 0682ed96cc..68ca75e1de 100644 --- a/nf_core/pipeline-template/workflows/pipeline.nf +++ b/nf_core/pipeline-template/workflows/pipeline.nf @@ -86,7 +86,7 @@ workflow {{ short_name|upper }} { ch_versions = ch_versions.mix(FASTQC.out.versions.first()) CUSTOM_DUMPSOFTWAREVERSIONS ( - ch_versions.collectFile() + ch_versions.unique().collectFile(name: 'collated_versions.yml') ) // From 56162a52dad0a73169f706521855caa985b2ce3d Mon Sep 17 00:00:00 2001 From: JoseEspinosa Date: Wed, 6 Oct 2021 22:58:24 +0200 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index dc696843c9..c11ad5dab0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ### Template * Modify software version channel handling to support multiple software version emissions (e.g. from mulled containers), and multiple software versions. +* Update `dumpsoftwareversion` module to correctly report versions with trailing zeros. ### General