Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit CI check-docs + /devel/generate-developer-api-docs #1764

Open
joverlee521 opened this issue Feb 25, 2025 · 0 comments
Open

Revisit CI check-docs + /devel/generate-developer-api-docs #1764

joverlee521 opened this issue Feb 25, 2025 · 0 comments

Comments

@joverlee521
Copy link
Contributor

Context

Following up on comments in #1762

Currently the CI does a fresh install of the dev dependencies during the check-docs job and flags changes in the API docs that need to be regenerated. However, if devs do not have a fresh environment locally, then they may not see the same changes when running /devel/generate-developer-api-docs (e.g. #1760 (comment)).

Possible solutions

  1. Document the need to run /devel/generate-developer-api-docs in a fresh environment
  2. Add upper pins to dev dependencies. This would guard us against upstream breakages like _stringify_annotation patch breaks in Sphinx==8.2.0 tox-dev/sphinx-autodoc-typehints#523 and devs would only need to update their local envs when the pins are updated. However, then we'd have to deal with the churn of updating the dependency pins as needed.
  3. Update /devel/generate-developer-api-docs to create it's own venv before regenerating the docs
  4. others?
@joverlee521 joverlee521 mentioned this issue Feb 25, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant