From ee13ccd1781789b96e72ae263c1f66ab55a26df5 Mon Sep 17 00:00:00 2001
From: Florian Klinger <florian.klinger@nextcloud.com>
Date: Fri, 5 Jan 2024 14:57:01 +0100
Subject: [PATCH] Removed unnecessary lines and added error reporting

Signed-off-by: Florian Klinger <florian.klinger@nextcloud.com>
---
 lib/Controller/SettingsController.php | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/lib/Controller/SettingsController.php b/lib/Controller/SettingsController.php
index da4ff0d9..589e2193 100644
--- a/lib/Controller/SettingsController.php
+++ b/lib/Controller/SettingsController.php
@@ -38,6 +38,7 @@
 use OCP\Http\Client\IClientService;
 use OCP\IRequest;
 use OCP\Security\ICrypto;
+use Psr\Log\LoggerInterface;
 
 class SettingsController extends Controller {
 
@@ -51,6 +52,8 @@ class SettingsController extends Controller {
 	private $crypto;
 	/** @var IClientService */
 	private $clientService;
+	/** @var LoggerInterface */
+	private $logger;
 
 	public function __construct(
 		IRequest $request,
@@ -58,7 +61,8 @@ public function __construct(
 		ID4MeService $id4meService,
 		ProviderService $providerService,
 		ICrypto $crypto,
-		IClientService $clientService
+		IClientService $clientService,
+		LoggerInterface $logger
 	) {
 		parent::__construct(Application::APP_ID, $request);
 
@@ -67,6 +71,7 @@ public function __construct(
 		$this->providerService = $providerService;
 		$this->crypto = $crypto;
 		$this->clientService = $clientService;
+		$this->logger = $logger;
 	}
 
 	public function isDiscoveryEndpointValid($url) {
@@ -97,12 +102,9 @@ public function isDiscoveryEndpointValid($url) {
 						$result['missingFields'][] = $field;
 					}
 				}
-			} else {
-				// Set isReachable to false if http code wasn't 200
-				$result['isReachable'] = false;
 			}
 		} catch (Exception $e) {
-			$result['isReachable'] = false;
+			$this->logger->error('Error - discovery endpoint validation: ' . $e);
 		}
 
 		return $result;