-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CommonMark test to 0.30 #2217
Comments
Actually 0.29 should currently be in use d7de7d9 The reason those tests were added is mainly because text does multiple conversion steps
The tests were mainly to ensure that with those different intermediate steps, we still stick to the expected format. https://github.com/nextcloud/text/blob/master/src/tests/markdown.spec.js#L25-L49 There were some test failures last time only due to additional whitespace which were skipped in the linked spec file, so might be worth to have a look at the actual failures if those are also related to that or something more serious. |
Thanks for the explanation @juliushaertl |
But the commonmark tests only test markdown-it, they do no test the markdown->html->markdown pipeline, that would require using |
Any news on that? @vinicius73 Do you still feel it's worth updating? If not, let's close this. |
Now it is used 0.28 (2017-08-01) version of CommonMark Spec in tests.
But there are two new releases
Actually the last version is 0.30, and this is supported by markdown-it
I've tried a fast update, but some tests failed.
Also, do we really need to test it? markdown-it already test it.
The text was updated successfully, but these errors were encountered: