-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing newly created task fails #233
Comments
@raimund-schluessler you're using the cdav-library? |
@skjnldsv The Problem is I didn’t send the PRODID on creation, so that SabreDAV does not return an Etag. Do you know how I get the app version in JavaScript? |
@raimund-schluessler if you use the cdav library, the PUT is automatically followed by a PROPFIND :) |
You have to get that information from the PHP side:
|
Stupid question, but why do you need that? :) |
To put it into in the prodid of ics created by the calendar app 😉 |
@georgehrke Hum, we don't do that on contacts 🙈 |
Thanks a lot for the hints. Fix is in #234 |
Question, do we have a standard to name our PRODID ? :) |
I am not aware of any. But might make sense to follow the same one. 🙂 |
Calendar is using Let me use the same |
Just so you know, we cannot do that for every browser. the trick we mentioned above does not work anymore on 16. I decided to use another way and implement it via webpack variables (taken from the package.json) |
Sounds like nextcloud/contacts#1010 is a good solution for that. |
Steps to reproduce
412 Precondition failed
.Expected behaviour
Editing a newly created task should work flawlessly, not matter how often you edit.
Actual behaviour
The second request will fail with
412 Precondition failed
.I will give details to the requests and what was send later (the etag is missing or wrong). Maybe @skjnldsv and @georgehrke Could have a look already.
Edit: I will check if
X-Sabre-Ew-Gross: iCalendar validation warning: PRODID MUST appear exactly once in a VCALENDAR component
is the reason.Edit2: Yes, this was the problem.
Creating request (inquiry header):
Creating request (response header):
First edit request (inquiry header):
First editing request (response header):
Second editing request (inquiry header):
Second editing request (response header)
The text was updated successfully, but these errors were encountered: