-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signaling "Typing indicators" #9272
Comments
Maybe the transient data objects could be re-used for this: A user could set a property when typing starts and remove it when it ended, so no need for periodic messages. Only thing that needs to be added is to remove the property when a session disconnects while typing. |
What is the reason to send a signaling message in periodic intervals? Would it not be enough just to send
Do you mean in the clients or in the signaling server itself? Besides that, the transient data would be something like Nevertheless, although the transient data looks like a good fit if typing indicators are also added to the internal signaling server maybe it would be better to use signaling messages in both cases for simplicity/consistency. After all, if |
Periodic messages should be avoided, that's why I suggested the transient data.
The key length is currently not limited. I was thinking that every session can always set a key
Right, the clients don't have to make sure that any current state has to be sent to newly connected clients with the transient data. Keep in mind that this would have to be implemented for web and the mobile clients independently. With the transient data you get it for free. But sure, if you want to support the internal signaling for typing indicators, it must be done that way. |
That was my "dumb" assumption of being less work :P |
The advantage of using transient data here would be some kind of "initial state". When we only send started/stopped events once, you'll never see a typing indicator when you enter a conversation. Theoretically if you write a text and never reach the "stopped" threshold, newly joined clients would never see that you're typing right now. |
After discussing with @danxuliu we noted that we had were different assumptions about how typing indicators would work with signaling messages, so some notes:
|
The text was updated successfully, but these errors were encountered: