From b3d836332720f8e1be7d9392fa76a20733ff5a10 Mon Sep 17 00:00:00 2001 From: Claus-Justus Heine Date: Thu, 3 Feb 2022 08:56:24 +0100 Subject: [PATCH 1/3] Prevent the OpenDocument preview generator from trying to open empty files. Rationale: does not make sense, and triggers a deprecation error in \ZipArchive. Signed-off-by: Claus-Justus Heine --- lib/private/Preview/Bundled.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/private/Preview/Bundled.php b/lib/private/Preview/Bundled.php index df7f630dff71f..812385c16725f 100644 --- a/lib/private/Preview/Bundled.php +++ b/lib/private/Preview/Bundled.php @@ -31,6 +31,11 @@ */ abstract class Bundled extends ProviderV2 { protected function extractThumbnail(File $file, string $path): ?IImage { + + if ($file->getSize() == 0) { + return null; + } + $sourceTmp = \OC::$server->getTempManager()->getTemporaryFile(); $targetTmp = \OC::$server->getTempManager()->getTemporaryFile(); $this->tmpFiles[] = $sourceTmp; From 456679c6fbdfd962a7b8ce2f69be10fd2b2082ba Mon Sep 17 00:00:00 2001 From: Claus-Justus Heine Date: Mon, 14 Feb 2022 23:48:14 +0100 Subject: [PATCH 2/3] Update lib/private/Preview/Bundled.php Co-authored-by: Carl Schwan --- lib/private/Preview/Bundled.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Preview/Bundled.php b/lib/private/Preview/Bundled.php index 812385c16725f..bbe2fcf30ea54 100644 --- a/lib/private/Preview/Bundled.php +++ b/lib/private/Preview/Bundled.php @@ -32,7 +32,7 @@ abstract class Bundled extends ProviderV2 { protected function extractThumbnail(File $file, string $path): ?IImage { - if ($file->getSize() == 0) { + if ($file->getSize() === 0) { return null; } From 800f40b71c65a11034eb4b5d28c7b83fb8687357 Mon Sep 17 00:00:00 2001 From: Simon L Date: Mon, 17 Apr 2023 17:18:09 +0200 Subject: [PATCH 3/3] fix php-lint Signed-off-by: Simon L --- lib/private/Preview/Bundled.php | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/private/Preview/Bundled.php b/lib/private/Preview/Bundled.php index bbe2fcf30ea54..2a408b90c4e1c 100644 --- a/lib/private/Preview/Bundled.php +++ b/lib/private/Preview/Bundled.php @@ -31,7 +31,6 @@ */ abstract class Bundled extends ProviderV2 { protected function extractThumbnail(File $file, string $path): ?IImage { - if ($file->getSize() === 0) { return null; }