Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Theming Support #9737

Closed
c0fe opened this issue Jun 4, 2018 · 6 comments
Closed

Advanced Theming Support #9737

c0fe opened this issue Jun 4, 2018 · 6 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: theming

Comments

@c0fe
Copy link

c0fe commented Jun 4, 2018

I have a suggestion for Nextcloud to provide either documentation or support for better theming options. I am basing this on how Wordpress has structured their CMS and how it supports themes. If you design a theme, you have to make various designs for different parts of the CMS features, such as menus. This is done through PHP hooks, which simplify the process from the designers perspective.

I figured that the various features of Nextcloud can be setup so they are called out by the PHP hooks which would allow for much more different designs of Nextcloud.

@MorrisJobke
Copy link
Member

We plan to not provide more options for theming. The theming app should the the go-to approach of how you could theme it. In the past custom themes caused people a lot of work and were not stable enough to survive more than a few patch releases.

Setting logos and colors is all that we will support in the near future. And there is nothing on the roadmap to drastically change this.

cc @nextcloud/theming @nextcloud/designers

@MorrisJobke MorrisJobke added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: theming labels Jun 4, 2018
@c0fe
Copy link
Author

c0fe commented Jun 4, 2018

@MorrisJobke I am curious as to why that is, most themes for Wordpress can survive version updates without problems. It is only problematic for major version jumps and even then it is more kick the tires and walk around to see if everything is there. I figured that was the beauty of PHP.

@juliusknorr
Copy link
Member

juliusknorr commented Jun 4, 2018

As @MorrisJobke said, offering theming like wordpress is doing it would have to much potential of breakage. Having some hooks might work well for Wordpress, since those are basically static sites that are generated. In Nextcloud there is a lot of JavaScript for the frontend, so a lot of dirty hacks would be required to make all the different things themable.

It is only problematic for major version jumps and even then it is more kick the tires and walk around to see if everything is there. I figured that was the beauty of PHP.

That is acutally another reason against more advanced theming. Once we introduce it, it needs to be maintained and tested for every release. That would be a huge amount of code, that complicated things a lot.

@c0fe
Copy link
Author

c0fe commented Jun 4, 2018

@juliushaertl i see, i was not aware of the extent javavscript plays a store, if it does that much then yeah it would be a mess.

@MorrisJobke
Copy link
Member

We tried it in the past and it was a huge problem for many people. Nowadays nearly everybody loves the theming app and we try to extend it with useful features (like dedicated favicon for 14 or the GDPR links for 13). Let's close it for now - thanks for the idea nevertheless.

@jancborchardt
Copy link
Member

Also, let's keep in mind that we can't really compare Nextcloud and Wordpress. Wordpress themes are very important because it's basically website designs, facing outward – everything needs to be adjuatable. For Nextcloud, it's mostly an internal tool with sometimes collaboration – theming does not need to be as extensive here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: theming
Projects
None yet
Development

No branches or pull requests

4 participants