Federated shares should use share_folder config setting

[ghost]

Expected behavior

Remote shares should use the "default folder for shared files and folders other than root".
The received file should be stored in the defined folder.

https://github.com/nextcloud/server/blob/stable9/config/config.sample.php#L1066-L1069

Actual behavior

The received files stored in the root.

Steps to reproduce the behavior

1. Create a federated file share on server one.
2. Accept the remote file share on server two.
3. On server two, take a look into the share folder, defined in config.php.

Server configuration

Nextcloud version:
9.0.53 (stable)

Updated from an older Nextcloud/ownCloud or fresh install:
ownCloud 9.0.3 -> Nextcloud 9.0.50 -> … -> 9.0.53

List of activated apps:

App list

  …
  - federatedfilesharing: 0.1.0
  - federation: 0.0.4
  - files: 1.4.4
  …
  - files_sharing: 0.9.1
  …

The content of config/config.php:

Config report

  …
  'share_folder' => '/Shared',
  …

---

Is it a bug, a feature, or by design?

[nickvergessen]

I'd say by design and IIRC the setting is deprecated.

@schiessle @rullzer

[MorrisJobke]

I'd say by design and IIRC the setting is deprecated.

Really? Since when?

[schiessle]

No, it is not deprecated... I think it would make sense to use it for federated shares as well.

[ghost]

Do we have a chance to see this issue fixed in v12?

[MorrisJobke]

I don't think so, because we have still a lot of other stuff to do for v12

[ghost]

Any news about this issue?