Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues running tests #4440

Closed
georgehrke opened this issue Apr 22, 2017 · 3 comments
Closed

Issues running tests #4440

georgehrke opened this issue Apr 22, 2017 · 3 comments
Labels
3. to review Waiting for reviews

Comments

@georgehrke
Copy link
Member

georgehrke commented Apr 22, 2017

./autotest.sh sqlite works fine without errors (also executes dav tests)

./autotest.sh sqlite apps/dav throws plenty of ::__construct() must implement interface OCP\IDBConnection, null given errors

phpunit --bootstrap tests/bootstrap.php -c apps/dav/tests/unit/phpunit.xml throws the same errors.

@LukasReschke was also able to reproduce this

All three commands work just fine on stable11.

Server configuration

Operating system: ubuntu 17.04

Web server: apache

Database: sqlite / mysql

PHP version: 7.0.15-1ubuntu4

PHPUnit version: 5.7.19

Nextcloud version: 1bd3bd3 (but also before, not stable11)

@georgehrke georgehrke added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Apr 22, 2017
@juliusknorr
Copy link
Member

I had the same issues running tests of the deck app locally. Those were caused by test classes that inherited from \Test\TestCase that implemented a setup method without calling parent::setUp().

Adding those fixed it for me, maybe that is also the case somewhere in the dav app.

@georgehrke
Copy link
Member Author

Hm. no.
parent::setUp() is present everywhere in the dav app :/

@georgehrke
Copy link
Member Author

@juliushaertl It was indeed a missing parent::setUp()
But why does a missing parent::setUp() in one test break everything else? 😖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

No branches or pull requests

2 participants