Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Theme color not applied properly to icons #42517

Closed
4 tasks done
SMH17 opened this issue Dec 29, 2023 · 4 comments
Closed
4 tasks done

[Bug]: Theme color not applied properly to icons #42517

SMH17 opened this issue Dec 29, 2023 · 4 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug feature: theming

Comments

@SMH17
Copy link

SMH17 commented Dec 29, 2023

⚠️ This issue respects the following points: ⚠️

Bug description

After the recent upgrade to Nextcloud 28 the theme color for icons isn't applied correctly anymore.

In this picture you can see the folder icon color correctly matches the theme color, archive and document icons ignore the selected color.
sample_bugx

Steps to reproduce

  1. Select a custom theme color
  2. Upload a compressed archive
  3. Check the icon color in nextcloud web GUI

Expected behavior

Theme color should be applied consistently to choice.

Installation method

Community Manual installation with Archive

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Update

@SMH17 SMH17 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Dec 29, 2023
@SMH17
Copy link
Author

SMH17 commented Feb 1, 2024

After the update to 28.0.2 the theme color is totally ignored even for folders and selection highlight.

This bug can be reproduced when it is selected "Dark Theme" in "Appearance and accessibility settings".

@susnux
Copy link
Contributor

susnux commented Mar 8, 2024

I think this might happen due to some places that still use the primary color instead of the every-where-else-used primary-element color.

@skjnldsv
Copy link
Member

skjnldsv commented May 23, 2024

// Previously, we used to pass this through Theming
// But it was only used to colour icons containing
// 0082c9. Since with vue we moved to inline svg icons,
// we can just use the default core icons.

I guess some icons are still not fixed 🙈
I think we can either:

  1. move mime icons to the default grey or their brand color (like docx being blue, pdf being red...)
  2. add back mime icon theming (I think this doesn't really add much anyway and is over engineered)

@susnux
Copy link
Contributor

susnux commented May 23, 2024

In this picture you can see the folder icon color correctly matches the theme color, archive and document icons ignore the selected color.

I have to correct myself. This is by design.
Folders are color primary, while documents are by design always that blue.
Like pdf is always red, documents are always blue.

@susnux susnux closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug feature: theming
Projects
None yet
Development

No branches or pull requests

5 participants